Apply Nullability to spring-integration-jmx module
#10166
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related to: spring-projects#10083 Signed-off-by: Jiandong Ma <[email protected]>
Contributor
Author
local build is green, please help me to re-trigger build process. |
artembilan
requested changes
Jun 27, 2025
.../src/main/java/org/springframework/integration/jmx/NotificationPublishingMessageHandler.java
Outdated
Show resolved
Hide resolved
...ain/java/org/springframework/integration/jmx/config/IntegrationMBeanExportConfiguration.java
Outdated
Show resolved
Hide resolved
...jmx/src/main/java/org/springframework/integration/monitor/IntegrationJmxAttributeSource.java
Show resolved
Hide resolved
artembilan
reviewed
Jun 27, 2025
| Collection<String> autoCreateChannelCandidatesNames = | ||
| (Collection<String>) new DirectFieldAccessor(bean).getPropertyValue("channelNames"); | ||
| this.siBeanNames.addAll(autoCreateChannelCandidatesNames); | ||
| this.siBeanNames.addAll(Objects.requireNonNull(autoCreateChannelCandidatesNames)); |
artembilan
requested changes
Jun 27, 2025
.../src/main/java/org/springframework/integration/jmx/NotificationPublishingMessageHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jiandong Ma <[email protected]>
artembilan
requested changes
Jun 27, 2025
| @Override | ||
| protected void handleMessageInternal(Message<?> message) { | ||
| this.delegate.publish(this.notificationMapper.fromMessage(message)); | ||
| this.delegate.publish(Objects.requireNonNull(this.notificationMapper.fromMessage(message))); |
Member
There was a problem hiding this comment.
I don't think we need this Objects.requireNonNull() yet.
artembilan
approved these changes
Jun 27, 2025
Member
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
I think that's enough.
I'm taking this locally for final review an merge.
Some clean might still be included.
Thank you!
Member
|
Merged as: 0669e3a. I'll push some clean up a bit latter in the separate commit. Thank you again! |
Member
|
Here is follow up: f0591f6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to: #10083